Add missing Debug derives
#266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00xc
requested review from
alexandruag,
bonzini,
jiangliu and
roypat
as code owners
00xc
force-pushed
the
missing_derives
branch
2 times, most recently
from
6802d27 to
261c33d
Compare
lauralt
reviewed
Nov 20, 2023
Add free Debug derives plus a lint to prevent future issues. Signed-off-by: Carlos López <[email protected]>
Signed-off-by: Carlos López <[email protected]>
00xc
force-pushed
the
missing_derives
branch
from
261c33d to
7754e49
Compare
roypat
approved these changes
Nov 20, 2023
lauralt
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Add free
Debugderives plus a lint to prevent future missing derives.Requirements
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
N/AAll added/changed functionality has a corresponding unit/integrationtest.
Release" section of CHANGELOG.md (if no such section exists, please create one).
N/AAny newly addedunsafecode is properly documented.