Range inclusive size 1 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the check that denied InclusiveRanges where start was equal with end. Added a test to check that allocation succeds when there is a size 1 range before or after the requested range. Signed-off-by: AlexandruCihodaru <[email protected]>
AlexandruCihodaru
force-pushed
the
range_inclusive_size_1
branch
from
e0f295b
to
fdc0ad5
Compare
andreeaflorescu
approved these changes
Sep 13, 2022
alxiord
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Fixes #42
Allows creation of intervals where the start is equal with the end of the interval. This could also be the first PR from a series of changes that could enable use of interval_tree allocation engine for IdAllocator.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
unsafecode is properly documented.