set_log_base: use MmapRegion::bitmap() directly #294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
For use in QEMU, I would like GuestMemoryRegion to return a BitmapSlice instead of a &Bitmap (rust-vmm/vm-memory#324). This adds some flexibility that QEMU needs in order to support a single global dirty bitmap that is sliced by the various GuestMemoryRegions.
However, this removes access to the BitmapReplace trait, because it is of course not possible to replace a slice of the bitmap only. Fortunately, vhost is built around the GM<> type alias, which has a pluggable bitmap type but hardcodes the backend:
and therefore
regionis known to be a GuestRegionMmap. Adding a single dereference of the GuestRegionMmap returns the MmapRegion to which the bitmap is attached, thus calling MmapRegion::bitmap() instead of ::bitmap().The change works either with or without the changes in vm-memory.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.