vhost-device-sound: pipewire: Fix rand module imports
#808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorindabassey
requested review from
stsquad,
vireshk,
stefano-garzarella and
epilys
as code owners
dorindabassey
force-pushed
the
rand
branch
2 times, most recently
from
41fbbd9 to
acb2fb1
Compare
|
@dorindabassey @stefano-garzarella I think instead of basing this PR on #803, you should base it on |
This commit updates rand dependencies and rand imports to use `rand::distr` instead of `rand::distributions`, ensuring compatibility with the latest rand crate version. the commit also replaces `rand::thread_rng()` with `rand::rng()` to reflect API changes in `rand` and handle errors when creating a `Uniform<f32>` distribution. Signed-off-by: Dorinda Bassey <[email protected]>
stefano-garzarella
force-pushed
the
rand
branch
from
cb9c3cc to
8c5d894
Compare
stefano-garzarella
approved these changes
Feb 11, 2025
epilys
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This commit updates rand imports to use
rand::distrinstead ofrand::distributions, ensuring compatibility with the latest rand crate version. the commit also replacesrand::thread_rng()withrand::rng()to reflect API changes inrandand handle errors when creating aUniform<f32>distribution.depends on:
#803
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.