Make tests conditionally compile for x86 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinankjain
requested review from
russell-islam,
liuw and
NunoDasNeves
as code owners
NunoDasNeves
approved these changes
Jan 24, 2025
russell-islam
approved these changes
Jan 24, 2025
|
@jinankjain Could you please fix DCO failure? |
|
I don't know this this is issue? `Commit sha: 79ffd3c, Author: Jinank Jain, Committer: Jinank Jain; Expected "Jinank Jain [email protected]", but got "Jinank Jain [email protected]". Commit sha: 77f137b, Author: Jinank Jain, Committer: Jinank Jain; Expected "Jinank Jain [email protected]", but got "Jinank Jain [email protected]".` |
Current tests are focusing upon x86 register getting/setting. These tests are bound to fail on aarch64. Signed-off-by: Jinank Jain <[email protected]>
Signed-off-by: Jinank Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Some of these unit tests are targeted for x86 architecture, thus conditionally compile them on x86.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.