Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add image crate to trophy case #26

Merged
merged 5 commits into from
Sep 1, 2019
Merged

[WIP] add image crate to trophy case #26

merged 5 commits into from
Sep 1, 2019

Conversation

Shnatsel
Copy link
Member

image crate is audited, unsafe code removed as much as possible. Tracking issue #3 is closed. Just waiting on rustsec/advisory-db#135 before this can be merged.

@HeroicKatora I know you've done a lot of work on making image safer. I'd be glad to recognize it here if that's OK with you. I'm only counting the unsafety identified by @64 here right now.

@Shnatsel
Copy link
Member Author

Shnatsel commented Sep 1, 2019

@fintelia you've done a lot of work improving safety of image crate before safety-dance got started. Should we add your work to the unsafe block tally, or would you prefer to be credited separately?

@fintelia
Copy link

fintelia commented Sep 1, 2019

@Shnatsel either way works. Probably easier just to count all of them in the same tally?

@Shnatsel
Copy link
Member Author

Shnatsel commented Sep 1, 2019

I'll include it in the tally then. Thanks again for your hard work!

@Shnatsel Shnatsel merged commit 63a8ff4 into master Sep 1, 2019
@Shnatsel Shnatsel deleted the add-image branch September 1, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants