Skip to content

Conversation

@regexident
Copy link
Contributor

I needed to map trees from one node value type to another and implementing such a mapping via the existing public API was sub-optimal, while with access to the internals it turned out to be trivial.

@adamreichold
Copy link
Member

The Clippy lint is unrelated to your change but could fix it nevertheless? Thanks!

@regexident
Copy link
Contributor Author

The Clippy lint is unrelated to your change but could fix it nevertheless? Thanks!

Done.

@adamreichold
Copy link
Member

I'll give it some time for anybody else to have a look and merge if happy. Otherwise I'll merge it tomorrow.

@adamreichold adamreichold merged commit 78c6bd8 into rust-scraper:master Nov 30, 2024
5 checks passed
@regexident regexident deleted the map_values branch November 30, 2024 11:03
@regexident
Copy link
Contributor Author

@adamreichold is there a chance to get a release cut with this?

@adamreichold
Copy link
Member

@cfvescovo Would you be up to releasing the current state of affairs as 0.9.1?

@cfvescovo
Copy link
Member

I may have to do some git tricks to release your fix as 0.9.1 and then the current state (with sort) as 0.10.0. If it's okay for you I will do it this evening (CET time)

@adamreichold
Copy link
Member

If you aim for that, then just release 0.10.0 and we'll bump scraper as well. I was suggesting 0.9.1 because we are 0.x and did not make any incompatible changes, i.e. even sort could be in 0.9.1 as it just adds new API surface.

@cfvescovo
Copy link
Member

cfvescovo commented Dec 9, 2024

Ok, so I will release 0.10.0. I like keeping patch version bumps for hot fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants