BlockRng: make core public and remove inner() and inner_mut() #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pitdicker what do you think?
I believe I found a bug regarding
half_used
......which brings me to a related point: didn't you mention trying to transmute the output of generate from
[u64]
to[u32]
then using the sameBlockRng
code in (or instead of)BlockRng64
?I don't like the way
half_used
works right now; it could make it difficult to reproduce RNG output in other implementations.