Fix documentation of fns rand_core::le::read_u*_into #1626
Merged
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
approved these changes
Apr 10, 2025
|
I would, but that's technically a breaking change. |
|
Technically, yes. But I think it's fine since I don't think any downstream users rely on the non-equal case and we could declare that it's a "bug fix" (if we are to stretch the meaning far enough). We had a similar "breaking change" in |
vks
approved these changes
Apr 11, 2025
|
Why do you want to change the assert? I don't really see the harm, any unused source bytes are just ignored. |
|
Unused input bytes are a possible indicator of mis-use. But I think it's best not to change the assert now (possibly on the next breaking change, but not important). |
mingulov
added a commit
to mingulov/rand
that referenced
this pull request
May 17, 2025
The file `rand_core/src/.le.rs.kate-swp` was unintentionally added in PR rust-random#1626. This commit removes the extraneous file.
benjamin-lieser
pushed a commit
that referenced
this pull request
May 19, 2025
# Summary The file `rand_core/src/.le.rs.kate-swp` was unintentionally added in PR #1626. This commit removes the extraneous file. # Motivation This file is a temporary editor swap file and serves no purpose in the repository. It was likely added accidentally. # Details No changes for `CHANGELOG.md` - it is a minor change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some documentation, as pointed out in #1624.
I considered deprecating or renaming these
fns, but they have some utility and only really need doc fixes.