Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename gen_iter → random_iter, misc.. #1500

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Rename gen_iter → random_iter, misc.. #1500

merged 9 commits into from
Oct 1, 2024

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Sep 28, 2024

  • Added a CHANGELOG.md entry

This extracts the non-inherent-methods stuff from #1492.

@dhardy dhardy requested a review from newpavlov September 28, 2024 08:36
newpavlov
newpavlov approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's also worth to rename gen_range to random_range?

@dhardy
Copy link
Member Author

dhardy commented Sep 28, 2024

Maybe... but it's longer and a significant breaking change.

@dhardy dhardy merged commit 66b11eb into rust-random:master Oct 1, 2024
15 checks passed
@dhardy dhardy deleted the rng branch October 1, 2024 13:59
@dhardy dhardy mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newpavlov newpavlov newpavlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhardy @newpavlov