Apply rustfmt and fix Clippy warnings #1448
Conversation
| @@ -50,6 +50,7 @@ | |||
| #![doc(test(attr(allow(unused_variables), deny(warnings))))] | |||
| #![no_std] | |||
| #![cfg_attr(feature = "simd_support", feature(portable_simd))] | |||
| #![allow(unexpected_cfgs)] | |||
There was a problem hiding this comment.
This can be removed after renaming doc_cfg to docsrs.
There was a problem hiding this comment.
I probably will leave fixing it for a later PR. We also should consider using doc_auto_cfg (it has certain issues, but I am not sure they affect us).
There was a problem hiding this comment.
Can we leave it to a later PR anyway?
| @@ -387,6 +379,7 @@ pub trait Weight: Clone { | |||
| /// - `Result::Err`: Returns an error when `Self` cannot represent the | |||
| /// result of `self + v` (i.e. overflow). The value of `self` should be | |||
| /// discarded. | |||
| #[allow(clippy::result_unit_err)] | |||
There was a problem hiding this comment.
Should we introduce a separate error type as suggested by this lint?
There was a problem hiding this comment.
You mean leave the allow for now and introduce new error type in a later PR?
There was a problem hiding this comment.
No. Given how much needs reformatting, it should be in a dedicated PR (not mixed up with Clippy / other fixes).
There was a problem hiding this comment.
Doing so will be REALLY annoying to untangle and I would strongly prefer to do both formatting and fixing of Clippy lints in one PR.
There was a problem hiding this comment.
This attr still shouldn't be here. Let Clippy complain in the CI if necessary.
There was a problem hiding this comment.
It would fail the CI job. Are you ready to merge a PR with a failing CI job? What is the reason to leave it for a later PR? If it's just to make 2 "clear" commits in the git history instead of just one, I don't think it's worth the associated trouble.
|
I suggest to also remove |
It certainly needs reviewing — removing is acceptable. |
| @@ -387,6 +379,7 @@ pub trait Weight: Clone { | |||
| /// - `Result::Err`: Returns an error when `Self` cannot represent the | |||
| /// result of `self + v` (i.e. overflow). The value of `self` should be | |||
| /// discarded. | |||
| #[allow(clippy::result_unit_err)] | |||
| @@ -50,6 +50,7 @@ | |||
| #![doc(test(attr(allow(unused_variables), deny(warnings))))] | |||
| #![no_std] | |||
| #![cfg_attr(feature = "simd_support", feature(portable_simd))] | |||
| #![allow(unexpected_cfgs)] | |||
There was a problem hiding this comment.
Can we leave it to a later PR anyway?
Closes #1429