Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Rng::gen to Rng::random #1438

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Rename Rng::gen to Rng::random #1438

merged 5 commits into from
Apr 29, 2024

Conversation

vks
Copy link
Collaborator

@vks vks commented Apr 26, 2024

Fixes #1435.

src/rng.rs Outdated Show resolved Hide resolved
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Unfortunately it's going to conflict with #1439!

CHANGELOG.md Outdated Show resolved Hide resolved
src/rng.rs Outdated Show resolved Hide resolved
vks added 4 commits April 29, 2024 19:14
This anticipates `gen` being a keyword in Rust 2024. A deprecated alias
for `Rng::gen` stays in place to make the transition easier.

Fixes rust-random#1435.
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhardy dhardy merged commit 4f8257a into rust-random:master Apr 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHANGE: Rename Rng::gen to avoid conflicting with a keyword in Rust 2024
3 participants