Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redundant import warnings #1405

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix redundant import warnings #1405

merged 1 commit into from
Mar 7, 2024

Conversation

MichaelOwenDyer
Copy link
Member

  • Added a CHANGELOG.md entry

Summary

There are some warnings being thrown in the test (ubuntu-latest, x86_64-unknown-linux-gnu, nightly, minimal_versions) and test-miri GitHub actions due to redundant imports. I thought I would go ahead and remove them.

@MichaelOwenDyer MichaelOwenDyer marked this pull request as ready for review March 6, 2024 21:38
dhardy
dhardy approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

MSRV (1.60.0) passes.

The CI failures are due to non_local_definitions on nightly which is a false positive in my opinion; lets leave that as is.

@dhardy dhardy merged commit 304048b into rust-random:master Mar 7, 2024
10 of 12 checks passed
@MichaelOwenDyer MichaelOwenDyer deleted the Remove-redundant-imports branch March 7, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhardy dhardy dhardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelOwenDyer @dhardy