Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: improve random, thread_rng, ThreadRng docs #1257

Merged
merged 4 commits into from
Sep 30, 2022
Merged

Doc: improve random, thread_rng, ThreadRng docs #1257

merged 4 commits into from
Sep 30, 2022

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Sep 24, 2022

Closes #1256.

@newpavlov review please?

@dhardy
Copy link
Member Author

dhardy commented Sep 24, 2022

once-cell bumped its MSRV to 1.56.0 in the latest release. We should add a Cargo.lock.msrv as recommended in matklad/once_cell#201.

newpavlov
newpavlov approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@newpavlov newpavlov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As for the once-cell issue, ideally rust-version should be used for dependencies resolution, but alas...

@newpavlov
Copy link
Member

Another option is to remove once_cell from out dependency tree, as done by some other projects.

@dhardy
Copy link
Member Author

dhardy commented Sep 29, 2022

crossbeam 0.8.12 no longer depends on once_cell.

@dhardy dhardy merged commit 766c7ec into master Sep 30, 2022
@newpavlov
Copy link
Member

@dhardy
Maybe it's worth to enable the "automatically delete head branches" setting for this repository?

@dhardy
Copy link
Member Author

dhardy commented Sep 30, 2022

@newpavlov I reuse "work" branches — that's why it doesn't have a topical name. Which branches should be deleted? This should possibly be a new issue.

@newpavlov
Copy link
Member

newpavlov commented Sep 30, 2022 •
edited
Loading

It's just that I usually use per-feature branches, i.e. I create a new branch for every PR. I think you can keep reusing "work" branches even with automatic deletion, you would simply need to do remote push for each new PR.

yaronf
yaronf reviewed Nov 12, 2022
View reviewed changes
src/rngs/thread.rs
/// (every 64 kiB, as well as "soon" after a fork on Unix — see [`ReseedingRng`]
/// documentation for details).
///
/// Security must be considered relative to a thread model and validation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: threat -> threat

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this is merged already. Can you make a PR? (Should be possible through the GitHub web UI.)

@newpavlov newpavlov deleted the work7 branch May 22, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaronf yaronf yaronf left review comments

@newpavlov newpavlov newpavlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rand::random Documentation
3 participants
@dhardy @newpavlov @yaronf