Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable std by default #95

Closed
wants to merge 2 commits into from
Closed

Enable std by default #95

wants to merge 2 commits into from

Conversation

josephlr
Copy link
Member

Fixes #94

@newpavlov
Copy link
Member

You forgot to add default-features = false to no_std CI test. I think we can merge this and publish an update after the rand_core update lands.

@newpavlov newpavlov requested a review from dhardy August 20, 2019 09:02
dhardy
dhardy reviewed Aug 23, 2019
View reviewed changes
README.md
setting `default-features = false` in `Cargo.toml`. Without this feature, this
library is `no_std` for every supported target.

However, getting randomness
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting a paragraph with however is never good grammar...

@dhardy
Copy link
Member

dhardy commented Aug 23, 2019

Isn't it the other way around — rand libs are waiting on getrandom 0.2 to be published? A breaking change is a breaking change, regardless of whether users have updated.

@josephlr
Copy link
Member Author

Closing in favor of #96. This change isn't the right way to fix #94

@josephlr josephlr closed this Aug 23, 2019
@josephlr josephlr mentioned this pull request Aug 23, 2019
Closed
@josephlr josephlr deleted the std branch August 25, 2019 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhardy dhardy dhardy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trait impl disappeared without bumping major version
3 participants
@josephlr @newpavlov @dhardy