Add support for getrandom syscall on NetBSD ≥ 10.0 #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
approved these changes
Jan 25, 2023
newpavlov
reviewed
Jan 25, 2023
NetBSD supports the getrandom system call since version 10.0 [1]. Use it if available, otherwise fall back to kern.arandom like on FreeBSD. [1] https://man.netbsd.org/getrandom.2
tklauser
force-pushed
the
netbsd-getrandom
branch
from
3ddcdf5 to
489f1e4
Compare
josephlr
added a commit
that referenced
this pull request
Jan 26, 2023
Followup to #331, we don't need the condidtional compilation anymore, because this file is only used if `any(target_os = "freebsd", target_os = "netbsd")` anyway. Also cleans up `use` statements and type declarations to look like those in macos.rs Signed-off-by: Joe Richey <[email protected]>
josephlr
added a commit
that referenced
this pull request
Jan 26, 2023
Followup to #331, we don't need the condidtional compilation anymore, because this file is only used if `any(target_os = "freebsd", target_os = "netbsd")` anyway. Also cleans up `use` statements and type declarations to look like those in macos.rs Signed-off-by: Joe Richey <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetBSD supports the getrandom system call since version 10.0 [1]. Use it if available, otherwise fall back to kern.arandom like on FreeBSD.
[1] https://man.netbsd.org/getrandom.2