-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description about Cargo js feature for WebAssembly section #280
Add description about Cargo js feature for WebAssembly section #280
Conversation
You should add a clarification that the |
Okay I updated the doc specifically stating what you mentioned. I'm quite new to Rust in general so had to do some digging with this. Is it possible to enable specific feature when the crate type is binary for example? If yes, then example of this could be added to the docs. For one of my own projects I've enabled js feature like this: [dependencies.getrandom]
features = ["js"] |
Signed-off-by: Joe Richey <[email protected]>
This is now redundent, now that we've claried documentation in the WebAssembly support section Signed-off-by: Joe Richey <[email protected]>
@Kazhuu I've made some updates to the wording here. Hopefully this will help emphasize that this feature should generally be enabled on non-library crates (binary, benchmark, or test crates). I also removed the "Indirect Dependencies" Section as its now redundant. I'll give @newpavlov a chance to review this. Note that the CI failure is caused by an unrelated nightly bug, see: |
Thanks @josephlr! Now the wording is a lot better and conveys more clearly what is needed. Even the original text I wrote is not there anymore I learned from this experience 👍 |
Signed-off-by: Joe Richey <[email protected]>
Documentation improvement regarding #267.