Change software_interrupt to use min_const_generics #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this feature is stablized in the lastest nightly, no feature flags need to be added. Signed-off-by: Joe Richey <[email protected]>
|
@phil-opp, do you think we should add an explanation about why |
phil-opp
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
Awesome, thanks a lot!
Are you sure that this inline assembly works? The Rust compiler only checks inline asm when it's used, so it would be great if we could add a small test that uses this function.
That would be great! |
Signed-off-by: Joe Richey <[email protected]>
Added some additional tests to where we were testing the |
Done |
Signed-off-by: Joe Richey <[email protected]>
This was referenced Jun 4, 2021
josephlr
added a commit
that referenced
this pull request
Jun 4, 2021
Followup to #259. Code previously merged as part of #227. Signed-off-by: Joe Richey <[email protected]>
josephlr
added a commit
to josephlr/x86_64
that referenced
this pull request
Jul 18, 2021
Followup to rust-osdev#259. Code previously merged as part of rust-osdev#227. Signed-off-by: Joe Richey <[email protected]>
Freax13
pushed a commit
to Freax13/x86_64
that referenced
this pull request
Oct 17, 2021
Followup to rust-osdev#259. Code previously merged as part of rust-osdev#227. Signed-off-by: Joe Richey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this feature is stablized in the lastest nightly, no
feature flags need to be added.
Opening PR against the
nextbranch as this is a breaking change.Signed-off-by: Joe Richey [email protected]