Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export PhysAddrNotValid and VirtAddrNotValid #163

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Export PhysAddrNotValid and VirtAddrNotValid #163

merged 1 commit into from
Jun 19, 2020

Conversation

samueltardieu
Copy link
Contributor

Those two structs are exported by making the addr module public.

Close #162

@samueltardieu
Export PhysAddrNotValid and VirtAddrNotValid
07f28e2 
Those two structs are exported by making the `addr` module public.
@samueltardieu
Copy link
Contributor Author

Tell me if you would prefer to have an reexport at the top-level. I thought that exporting them as addr::VirtAddrNotValid and addr::PhysAddrNotValid would avoid polluting code completion for x86_64::Virt in IDE.

phil-opp
phil-opp approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick, thank you!

I thought that exporting them as addr::VirtAddrNotValid and addr::PhysAddrNotValid would avoid polluting code completion for x86_64::Virt in IDE.

Sounds reasonable!

@samueltardieu
Copy link
Contributor Author

cargo clippy run (using 1.46.0-nightly (feb3536eb 2020-06-09)) is clean for me, and the failed lints have nothing to do with this change.

@phil-opp
Copy link
Member

The clippy errors are because of rust-lang/rust-clippy#5704. I hope that rust-lang/rust-clippy#5705 lands soon so that the lint that causes the error is disabled by default.

@phil-opp phil-opp merged commit 3eb1532 into rust-osdev:master Jun 19, 2020
phil-opp added a commit that referenced this pull request Jun 19, 2020
@phil-opp
Update changelog for #163
3fb1621
@phil-opp
Copy link
Member

Published as version 0.11.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors are not public
2 participants
@samueltardieu @phil-opp