Add PcrEvent::new_in_box/PcrEventInputs::new_in_box #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-tcg-new-boxed
branch
2 times, most recently
from
eb28d30
to
f110e57
Compare
|
(Marking draft til I finish fixing errors) |
This is needed for make_boxed.
This is needed for make_boxed.
This is needed for make_boxed. Technically it's slightly less efficient, since the input buf must now be initialized, but in practice these structs are quite small and not created all that often, so there's no meaningful difference.
A manual implementation is required since this is a packed struct.
This is needed for make_boxed.
nicholasbishop
force-pushed
the
bishop-tcg-new-boxed
branch
from
f110e57
to
8bc7605
Compare
phip1611
approved these changes
Jul 16, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #780
The initial commits are modifying the structs so that the
make_boxedutility can be used.Checklist