Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable usage with non-nightly rust #7

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

haraldh
Copy link
Contributor

@haraldh haraldh commented Feb 21, 2020

default is "nightly"

to compile with stable rust:
uart_16550 = { version = "0.2.4", default-features = false, features = [ "stable" ] }

@haraldh haraldh force-pushed the stable branch 2 times, most recently from 20673a6 to 1069547 Compare February 21, 2020 14:22
@haraldh haraldh requested a review from phil-opp February 21, 2020 14:53
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me, except that I would make the conditional compilation about the nightly instead of stable feature (see inline comments below).

default is "nightly"

to compile with stable rust:
uart_16550 = { version = "0.2.4", default-features = false, features = [ "stable" ] }
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-opp phil-opp merged commit 5887465 into rust-osdev:master Feb 25, 2020
phil-opp added a commit that referenced this pull request Feb 25, 2020
@phil-opp
Copy link
Member

Published as version 0.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants