x86: crate finally builds with x86 and x86_64 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
x86
branch
3 times, most recently
from
e9e8ce9 to
5a119f1
Compare
|
Thanks for the PR! Could you
Could you give some more details on this? |
|
The x86_64 crate doesn't build with x86 for many reasons. I don't think it is possible to fix the x86_64 crate in a sensible way.
|
phil-opp
approved these changes
Aug 4, 2023
|
Published as v0.3.0. (This should be a non-breaking change. I still decided to do a new minor release in case there are some subtle differences in the API.) |
phil-opp
added a commit
that referenced
this pull request
Aug 4, 2023
|
Nice, thanks for merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables to actually use the crate with arch
x86and not justx86_64. I added CI steps to verify the build. It is a follow up to #28. I had to remove thex86_64dependency as it broke the build.Unfortunately, I had to remove your nice and convenient port abstraction from the
x86_64crate. As the ports are an internal API and not exposed to users, I think this is fine. However, it was not my intention to remove any of your work.. perhaps, you might have an idea for another/better solution?