Remove use of stable and nightly features
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now use `rustversion` to mark `MmioSerialPort::new()` as const or not depending on the rust version. The features can't be removed yet as that would be a breaking change. This removes code duplication and lets us avoid increasing our MSRV. Fixes rust-osdev#23 Signed-off-by: Joe Richey <[email protected]>
|
Published as v0.2.18 |
phil-opp
added a commit
that referenced
this pull request
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now use
rustversionto markMmioSerialPort::new()as const ornot depending on the rust version. The features can't be removed yet as
that would be a breaking change.
This removes code duplication and lets us avoid increasing our MSRV. We also no longer need any nightly features for
x86_64with the release of0.14.9.Fixes #23
Signed-off-by: Joe Richey [email protected]