Added send_raw() function to allow sending arbitrary binary data using the serial port. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the serial port.
Empty commit to trigger a CI build again.
phil-opp
approved these changes
Jan 8, 2022
|
Published as v0.2.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here: #19
The
send()function has a special case for 0x08 and 0x7F in order to allow terminals to correctly display ASCII backspace and delete characters. However, inserting the additional 0x08 0x20 bytes can mangle binary data being sent using the serial port. Thus, this PR adds a newsend_raw()function which allows sending bytes unchanged. By using a new function, this should not break backwards compatibility with previous versions of the crate.