Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use traits for register and uart #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use traits for register and uart #39

wants to merge 2 commits into from

Conversation

ChocolateLoverRaj
Copy link

@ChocolateLoverRaj ChocolateLoverRaj commented Feb 25, 2025 •
edited
Loading

Closes #38

Contain breaking changes

Advantages:

  • Reduces the amount of code
  • Lets people using this library use a uart with dyn Uart16550
  • It will be very easy to add another method in addition to port and mmio

Tested the port with qemu and tested the mmio on a real computer.

@ChocolateLoverRaj
Use traits for register and uart
94fe27e 
Contain breaking changes

Advantages:
- Reduces the amount of code
- Lets people using this library use a uart with `dyn Uart16550`
- It will be very easy to add another method in addition to port and mmio
@ChocolateLoverRaj ChocolateLoverRaj mentioned this pull request Feb 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put common code for the port and MMIO in a trait
1 participant
@ChocolateLoverRaj