The compiler_builtins library is now a crates.io dependency of alloc #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#56092 changed the build process of the sysroot in the following way:
The compiler_builtins is now a normal crates.io crate: https://crates.io/crates/compiler_builtins. Since compiler_buitlins depends on libcore, but no sysroot exists yet when building liballoc, it has a special
rustc-std-workspace-core
feature that overwrites the core dependency with an empty crates.io crate called rustc-std-workspace-core. This makes it possible to override thecore
dependency through apatch
section in the Cargo.toml of liballoc.For time reasons, this PR takes a different approach: Instead of using the
rustc-std-workspace-core
feature and apatch
section to buildcore
together with liballoc, we keep on buildingcore
first and then set the sysroot in RUSTFLAGS when compiling liballoc. This way, both liballoc and compiler_builtins use the core library that we built in the previous step.Fixes #22