Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mitigate undefined symbol _fltused #243

Closed
wants to merge 1 commit into from
Closed

mitigate undefined symbol _fltused #243

wants to merge 1 commit into from

Conversation

tsatke
Copy link
Contributor

@tsatke tsatke commented Jul 25, 2022 •
edited
Loading

This hopefully fixes the build until the issue is resolved in the linker.

Ref rust-lang/rust#62785

@bjorn3
Copy link
Contributor

bjorn3 commented Jul 25, 2022

The UEFI target is compiled with soft-float enabled. Shouldn't that suppress usage of _fltused? Or am I misunderstanding it's purpose? Also _fltused is still emitted on UEFI by compiler-builtins: https://github.com/rust-lang/compiler-builtins/blob/dffad9b98ac33c4e22a08397cfbcc52262ab1676/src/x86_64.rs#L77-L82 That will conflict with this definition, right?

@tsatke
Copy link
Contributor Author

tsatke commented Jul 26, 2022

@bjorn3 it fixed all problems with my bootloader fork.
However, the issue seems fixed with today's rust nightly, closing this.

@tsatke tsatke closed this Jul 26, 2022
@tsatke tsatke deleted the patch-1 branch July 26, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsatke @bjorn3