Allow deriving for no-std targets #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By pulling in `num-traits` as a direct dependency, we corrupt the feature selection for anybody using `num-derive` too, which makes it impossible to use on no-std targets. We really only need it for testing as a dev-dependency though.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 25, 2019
22: Allow deriving for no-std targets r=cuviper a=cuviper By pulling in `num-traits` as a direct dependency, we corrupt the feature selection for anybody using `num-derive` too, which makes it impossible to use on no-std targets. We really only need it for testing as a dev-dependency though. Co-authored-by: Josh Stone <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By pulling in
num-traitsas a direct dependency, we corrupt thefeature selection for anybody using
num-derivetoo, which makes itimpossible to use on no-std targets. We really only need it for testing
as a dev-dependency though.