Add "forwards" of the approx methods .abs_diff_eq and .relative_eq #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturner314
reviewed
Mar 18, 2021
src/array_approx.rs
Outdated
| /// approximate equality of two arrays. | ||
| /// | ||
| /// **Requires crate feature `"approx"`** | ||
| pub fn abs_diff_eq<B, S2>(&self, other: &ArrayBase<S2, D>, epsilon: A::Epsilon) -> bool |
There was a problem hiding this comment.
IMO, this would be better with a single type parameter for simplicity:
pub fn abs_diff_eq<S2>(&self, other: &ArrayBase<S2, D>, epsilon: A::Epsilon) -> bool
where
A: AbsDiffEq<S2::Elem>,
A::Epsilon: Clone,
S2: Data,
{}
src/array_approx.rs
Outdated
| /// apart; and the absolute difference otherwise. | ||
| /// | ||
| /// **Requires crate feature `"approx"`** | ||
| pub fn relative_eq<B, S2>( |
This is a nod to the all_close method that was removed. The replacement methods still require the "approx" feature gate, but we forward them as inherent methods on the array, to make them easier to call (no trait import needed).
|
Thanks for the input 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nod to the all_close method that was removed. The replacement
methods still require the "approx" feature gate, but we forward them as
inherent methods on the array, to make them easier to call (no trait
import needed).
Closes #763