Check expr type for expr;step in s![] macro at compile time, and remove AxisSliceInfo::step_by #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if the `expr;step` notation was used with an index as the `expr`, e.g. `s![4;2]`, the macro would panic at runtime. Now, it errors at compile time. This is accomplished by converting the `expr` to a `Slice` before converting it into the final `AxisSliceInfo`.
jturner314
force-pushed
the
remove-axissliceinfo-step_by
branch
3 times, most recently
from
c05db1c
to
7a20918
Compare
This method is awkward because it panics for all cases except the `Slice` variant. This method is no longer necessary because the `s![]` macro now calls `Slice::step_by()` instead.
jturner314
force-pushed
the
remove-axissliceinfo-step_by
branch
from
7a20918
to
7e1f7d7
Compare
bluss
approved these changes
Mar 16, 2021
|
Thanks. Would you like to describe your recent PRs in the change log? |
|
We can both push to #939 as long as it's open for example. Or just open up for PRs to add to the changelog by themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if the
expr;stepnotation was used with an index as theexpr, e.g.s![4;2], the macro would panic at runtime. Now, it errors at compile time. This is accomplished by converting theexprto aSlicebefore converting it into the finalAxisSliceInfo.The
AxisSliceInfo::step_bymethod is awkward because it panics for all cases except theSlicevariant. This method is no longer necessary because thes![]macro now callsSlice::step_by()instead.