Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ci #848

Merged
merged 6 commits into from
Nov 28, 2020
Merged

Fix ci #848

merged 6 commits into from
Nov 28, 2020

Conversation

ZuseZ4
Copy link
Contributor

@ZuseZ4 ZuseZ4 commented Nov 11, 2020

Solving #828

@ZuseZ4
Copy link
Contributor Author

ZuseZ4 commented Nov 12, 2020

@xd009642 I don't have the rights to merge this, but it should be fine if we agree to bump the MSRV to 1.42, I guess?
1.42 is the earliest version to allow fixing all lints from the current clippy version.

@xd009642
Copy link
Contributor

I also don't have rights to merge but it looks good to me imo. I think maybe @jturner314 and @bluss are the two people to go to for approval + merge 👀

@ZuseZ4 ZuseZ4 mentioned this pull request Nov 12, 2020
Merged
@xd009642
Copy link
Contributor

@bluss @jturner314

@xd009642 xd009642 mentioned this pull request Nov 27, 2020
Merged
@bluss
Copy link
Member

bluss commented Nov 28, 2020

Solid thanks

@bluss bluss merged commit a224232 into rust-ndarray:master Nov 28, 2020
@ZuseZ4 ZuseZ4 mentioned this pull request Nov 28, 2020
Closed
@ZuseZ4 ZuseZ4 deleted the fix_CI branch November 30, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZuseZ4 @xd009642 @bluss