Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternate form flag (#) to disable overflow with ellipsis #707

Merged
merged 3 commits into from
Sep 15, 2019

Conversation

jturner314
Copy link
Member

Currently, there is no way to print all the elements of an array if one of the axis lengths exceeds the limit before overflowing with an ellipsis. This PR makes it so that if the alternate form flag (#) is specified, the axis length limit is disabled. It also simplifies the array formatting implementation.

Fixes #705.

@bluss
Copy link
Member

bluss commented Sep 12, 2019

Thanks! Do you think we can increase the limit? For 1D/2D arrays the current limit seems a bit low, but I know the number of elements we show scales up pretty hard for high dimensional arrays. (I have now seen you brilliant comment on this topic in #705).

Copy link
Member

@bluss bluss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice refactoring, so let's merge it

@bluss bluss merged commit f489851 into rust-ndarray:master Sep 15, 2019
@jturner314 jturner314 deleted the alt-form-format branch September 16, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to print the whole array
2 participants