Use matrixmultiply cgemm and improve tests #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
force-pushed
the
matmul-complex
branch
2 times, most recently
from
02f511c
to
37eae14
Compare
Refactor tests to use generics in a bit smarter way. We test both .dot() and general_mat_mul. Tests now use relative accuracy more explicitly (this works better with generics, instead of using approx).
bluss
force-pushed
the
matmul-complex
branch
from
693c5ff
to
67e805b
Compare
|
Here I wonder if complex support in general should be optional and opt-in, might be a less used feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tests to use generics in a bit smarter way.
We test both .dot() and general_mat_mul. Tests now use relative accuracy
more explicitly (this works better with generics, instead of using
approx).
This follows up previous change #1106 by improving the default/
fallback for
Complex<f32>andComplex<f64>by usingmatrixmultiply.
This performance improvement is already good (2-3x on small problems),
but enabling BLAS should be much better.