ndk/native_window: Add bindings to convert to and from Java Surface representation
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… representation `ANativeWindow` is the C counterpart to the `android.view.Surface` object in Java, and has these functions available to convert between the C and Java (JNI representation) variant of it.
maxammann
approved these changes
May 13, 2022
|
Looks good, haven't tested this though |
|
I'll quickly try my luck to get this working :) Hold my coffee! :D |
maxammann
approved these changes
May 13, 2022
| /// `surface` is a valid pointer to an [`android.view.Surface`]. | ||
| /// | ||
| /// [`android.view.Surface`]: https://developer.android.com/reference/android/view/Surface | ||
| pub unsafe fn from_surface(env: *mut JNIEnv, surface: jobject) -> Option<Self> { |
There was a problem hiding this comment.
Do we somehow need to release this surface? (ANativeWindow_release)
There was a problem hiding this comment.
Nope! You'll get a NativeWindow here which already implements acquire/release semantics in clone() and drop(), respectively.
There was a problem hiding this comment.
I don't know if you need to retain the life of the surface JNI object (in Java land), though - https://developer.android.com/ndk/reference/group/native-activity#anativewindow_fromsurface doesn't specify 😞
All I know is that to_surface gives you a Java Surface which internally keeps the NativeWindow alive, so you don't need to do that at least.
1 task
dvc94ch
approved these changes
May 14, 2022
7 tasks
MarijnS95
added a commit
to rust-windowing/glutin
that referenced
this pull request
Jun 6, 2022
`winit` provides a `raw-window-handle` specifically for crates to process window pointers/references in a crate-agnostic way. `glutin` can use it too, to get rid of its `ndk-glue` dependency which otherwise has a hard versioning dependency as it should be updated in sync with `winit`. Over time this should be worked into the other backends, in turn removing `winit` from the `new_windowed()` function signature and replacing it with `impl HasRawWindowHandle` or `dyn HasRawWindowHandle`. This will also allow Android users to pass generic `Surface`s (first converted to a so-called `NativeWindow` in the NDK through [#272], then passed as `RawWindowHandle` thanks to [#274]) created in Java / Kotlin / Flutter to render to individual UI elements instead of the entire screen with a `NativeActivity` (`ndk-glue`). It'll in turn make the code more generic, too, as `raw-window-handle` has a variant for every platform / windowing system currently supported by glutin. [#272]: rust-mobile/ndk#272 [#274]: rust-mobile/ndk#274
MarijnS95
added a commit
to rust-windowing/glutin
that referenced
this pull request
Jun 7, 2022
`winit` provides a `raw-window-handle` specifically for crates to process window pointers/references in a crate-agnostic way. `glutin` can use it too, to get rid of its `ndk-glue` dependency which otherwise has a hard versioning dependency as it should be updated in sync with `winit`. Over time this should be worked into the other backends, in turn removing `winit` from the `new_windowed()` function signature and replacing it with `impl HasRawWindowHandle` or `dyn HasRawWindowHandle`. This will also allow Android users to pass generic `Surface`s (first converted to a so-called `NativeWindow` in the NDK through [#272], then passed as `RawWindowHandle` thanks to [#274]) created in Java / Kotlin / Flutter to render to individual UI elements instead of the entire screen with a `NativeActivity` (`ndk-glue`). It'll in turn make the code more generic, too, as `raw-window-handle` has a variant for every platform / windowing system currently supported by glutin. [#272]: rust-mobile/ndk#272 [#274]: rust-mobile/ndk#274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANativeWindowis the C counterpart to theandroid.view.Surfaceobject in Java, and has these functions available to convert between the C and Java (JNI representation) variant of it.