Remove the windows-sys dependency #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bindings are lifted from windows-sys, save for the structures used in minidump callbacks which are replaced with dummies (we don't use them and they use a zillion different types). This isn't great because I have to make the bindings public in order to use them from the tests; I'm not sure if there' s a way to expose them just to the test but not the the crate's users. |
gabrielesvelto
force-pushed
the
no-windows-sys-dependencies
branch
from
0cb8f15 to
6f94ecd
Compare
Jake-Shadle
requested changes
Oct 26, 2022
|
Oh nvm, it's because it's an outer attribute so applies to the main function so my change would also fix the build issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #58