Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump nightly -> 2023-12-28 #345

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

xFrednet
Copy link
Member

  • So much breakage 14/27 fixed

  • It compiles...

* So much breakage 14/27 done

* It compiles...
@xFrednet xFrednet marked this pull request as ready for review December 29, 2023 12:55
@xFrednet
Copy link
Member Author

@Veetaha The github action tests are failing, as they use a different nightly toolchain version than the one from the rust-toolchain.toml file. This wasn't an issue in the last release, since I accidentally messed up the toolchain version and updated it early, meaning that v0.4.3, tested by in the action had the same toolchain as v0.5.0 on the master branch.

Since the scripts are used for specific tags, can we just update the toolchain version in them as well, with the update-toolchain version script?

@Veetaha
Copy link
Contributor

Veetaha commented Dec 29, 2023

I don't think update-toolchain script is needed here. Try adding this step before cargo marker invocation to install the toolchain version used in this repo.

- uses: actions-rust-lang/setup-rust-toolchain@v1

@xFrednet xFrednet force-pushed the rustup-2023-12-28 branch 4 times, most recently from a09527d to 463c0df Compare December 30, 2023 14:07
@xFrednet xFrednet added this pull request to the merge queue Dec 30, 2023
Merged via the queue into rust-marker:master with commit 8f6ef00 Dec 30, 2023
26 checks passed
@xFrednet xFrednet deleted the rustup-2023-12-28 branch December 30, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants