Fixes #1298 fix not closed divs and add alt #1299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@camelid what do you think of this one? just fixed couple of not closed divs |
Member
|
It looks good to me, but I am not a maintainer of this project so you will need a review from someone else. Please squash your changes here as well with |
Member
|
By the way, can you add "fixes" before the issue number in this PR as well? |
dzhibas
changed the title
Contributor
|
Hi Rust team. This is really old. Should be easy to merge. |
Contributor
|
Looks good, but there are some conflicts now. I'll merge if they are resolved. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1298