Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rustc-guide to rustc-dev-guide #1029

Closed

Conversation

chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented Mar 10, 2020

The rustc-guide repository was moved to rustc-dev-guide and the new URL for the rustc-dev-guide is https://rustc-dev-guide.rust-lang.org/

The discussion about these changes is in rust-lang/rustc-dev-guide#470.

This PR revises rustc-guide references in this repository to the new name.

Transition tracker: rust-lang/rustc-dev-guide#602

@chrissimpkins
Copy link
Member Author

The transition is complete and this PR is ready for review/merge. Thanks!

@JohnTitor
Copy link
Member

I think translation will be done on pontoon side, so you don't have to update locales/ja/teams.ftl here.

@pietroalbini
Copy link
Member

Yep the translations have to be done through Pontoon.

@chrissimpkins
Copy link
Member Author

Reverted ja translation in 00f3413

@XAMPPRocky
Copy link
Member

I think there's some confusion here. The repository is the canonical source of the translations, and pontoon syncs to the repository, but changes aren't required to go through pontoon. In general, changes to translations should go through pontoon so that they go through proper review. But cases like this where it is the same word across all translations it's preferable to make the change in the PR to reduce the overall work.

@chrissimpkins Would you mind re-adding the japanese localisation and any others that are present?

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Mar 10, 2020

I only came across en-US and ja when I searched for rustc-guide.

I spot checked other localizations and it looks like the translations are using some form of "rustc guide" / "Rustc Guide" rather than the hyphenated English phrase. For instance, in it it is: "la guida rustc". Do we want to abandon this approach and fix the name as rustc-dev-guide or push translations through Pontoon with a new name "Rustc Dev Guide"?

cc @mark-i-m @spastorino

@mark-i-m
Copy link
Member

Hmm... my preference is to uniformly call it rustc-dev-guide everywhere, even changing it in English from "rustc guide" or "rustc dev guide" or variants.

@pietroalbini
Copy link
Member

I think there's some confusion here. The repository is the canonical source of the translations, and pontoon syncs to the repository, but changes aren't required to go through pontoon.

To be honest I didn't work much with the translations, but I thought changes were required to go through it. Oh well, everyone learns something every day :)

@chrissimpkins
Copy link
Member Author

Hmm... my preference is to uniformly call it rustc-dev-guide everywhere, even changing it in English from "rustc guide" or "rustc dev guide" or variants.

@mark-i-m Any idea how we do this? Is it sufficient to add this to the en-US and push to Pontoon or do we need to translate from localized writing systems?

@XAMPPRocky
Copy link
Member

Looking into this further, this PR is not actually needed at all. Since this info is autogenerated from the team repo. The current team repo doesn't mention rustc-guide at all, it's just that team data is quite out of date. I've filed #1030 to address that.

@XAMPPRocky XAMPPRocky closed this Mar 10, 2020
@chrissimpkins chrissimpkins deleted the rename-rustc-guide branch March 11, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants