-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename rustc-guide to rustc-dev-guide #1029
Conversation
The transition is complete and this PR is ready for review/merge. Thanks! |
I think translation will be done on pontoon side, so you don't have to update |
Yep the translations have to be done through Pontoon. |
Reverted ja translation in 00f3413 |
I think there's some confusion here. The repository is the canonical source of the translations, and pontoon syncs to the repository, but changes aren't required to go through pontoon. In general, changes to translations should go through pontoon so that they go through proper review. But cases like this where it is the same word across all translations it's preferable to make the change in the PR to reduce the overall work. @chrissimpkins Would you mind re-adding the japanese localisation and any others that are present? |
I only came across I spot checked other localizations and it looks like the translations are using some form of "rustc guide" / "Rustc Guide" rather than the hyphenated English phrase. For instance, in |
Hmm... my preference is to uniformly call it |
To be honest I didn't work much with the translations, but I thought changes were required to go through it. Oh well, everyone learns something every day :) |
@mark-i-m Any idea how we do this? Is it sufficient to add this to the en-US and push to Pontoon or do we need to translate from localized writing systems? |
Looking into this further, this PR is not actually needed at all. Since this info is autogenerated from the team repo. The current team repo doesn't mention rustc-guide at all, it's just that team data is quite out of date. I've filed #1030 to address that. |
The rustc-guide repository was moved to rustc-dev-guide and the new URL for the rustc-dev-guide is https://rustc-dev-guide.rust-lang.org/
The discussion about these changes is in rust-lang/rustc-dev-guide#470.
This PR revises
rustc-guide
references in this repository to the new name.Transition tracker: rust-lang/rustc-dev-guide#602