Run test #347
Run test #347
Conversation
| }, | ||
| "engines": { | ||
| "vscode": "^1.22.0" | ||
| "vscode": "^1.24.0" |
There was a problem hiding this comment.
We need this for the new tasks API. What vscode compatability strategy do we follow?
There was a problem hiding this comment.
Latest stable and insiders only for now
|
Here's how the UX looks: https://youtu.be/Lntgjpk18sk |
|
Apparently, the proper VS Code UI for this is code lens. Looking into implementing it! |
|
Seems to work:
:) |
|
Updated. |
It is used by the CodeLens feature to run the tests.
|
The RLS-side of this has been merged |
|
Thanks! |
|
The "Run test" button things have appeared in vscode with the latest nightly, but they don't seem to do anything at all - no debug logs from rls at all. Is there any explicit configuration that's needed? |
|
No, no config should be necessary. If you see the lens, that means that RLS side of things works, and the problem is within VS Code extension. |
|
This only happens on vscode 1.25. Curiously, the build-in |
|
Looks like microsoft/vscode#53673 |
|
Fixed by #361 |
|
Whoa! This is great! I just saw the "Run test" button appear under one of my |
|
@MajorBreakfast thanks! Thers’s still a ton of work to do to make this work properly :-) |
4 participants
Hi!
This is a proof of concept for #225, which, at least in my experience, is a huge productivity boost.
The current implementation approach here risks summoning Zalgo, I'll look into using save analysis data to detect available test and Cargo metadata to find out the proper cargo comman-line for this. OTOH, even this simplistic approach covers 80% of use-cases, so I think merging this almost as is (with some regex tweaking) might be a good idea as well.