This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Added custom path for rustup #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Oct 5, 2017
src/configuration.ts
Outdated
| @@ -44,14 +45,15 @@ export class RLSConfiguration { | |||
| * directory. | |||
| */ | |||
| public readonly rlsRoot: string | null; | |||
|
|
|||
There was a problem hiding this comment.
Ok, I will correct this and pay attention to this in future.
Thanks for pointing this out.
src/configuration.ts
Outdated
| public static loadFromWorkspace(): RLSConfiguration { | ||
| const configuration = workspace.getConfiguration(); | ||
|
|
||
| return new RLSConfiguration(configuration); | ||
| } | ||
|
|
||
| private constructor(configuration: WorkspaceConfiguration) { | ||
| this.rustupPath = configuration.get('rustup.path', 'rustup'); |
There was a problem hiding this comment.
Could you use something likerust-client.rustupPath for the configuration name please? Could you also add the option to the configuration section of package.json.
There was a problem hiding this comment.
Yeah, you are right.
I will submit patch when I get home.
|
Looks good, thanks! Could you rebase please? |
|
Sorry for the delay. |
|
Thank you! |
Closed
Xanewok
pushed a commit
to Xanewok/rls-vscode
that referenced
this pull request
Mar 27, 2019
…ng errors. (rust-lang#164) * Fixed erasing of a document on reformatting if the document has parsing errors. Fixed rust-lang#161. * Changed the condition checked to determine whether there are errors. * Removed the second part of the comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160