Handle re-opening of PRs under community reviews assignment - #2494
Merged
Conversation
Member
Author
|
Hum, there is technically the case of the assignee un-assigning themselves from the PR before it's re-opened, in that case there is enough approvals, but I don't know what to do in that case. The current logic in the PR only adds the label and doesn't not assign someone, same as with normal PRs. I guess we'll figure-out if we ever have this case. |
Kobzol
approved these changes
Aug 28, 2026
Urgau
force-pushed
the
assign-community-review-reopened
branch
from
August 28, 2026 16:21
cdaa6d3 to
ba939ee
Compare
Urgau
enabled auto-merge
August 28, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When PRs under community reviews assignment are closed we remove the label (eg.
S-waiting-on-community-reviews), which is expected, but we didn't added it back when the PR was being reopened, causing the PR to never get a assignee after reaching the desired minimum community reviews.This PR therefore adds the plumbing to re-add the label when the PR is being re-opened.
Reported at rust-lang/rust-clippy#17634 (comment)