Assign priority to issues from Zulip#2337
Open
apiraino wants to merge 1 commit intorust-lang:masterfrom
Open
Conversation
apiraino
commented
Mar 6, 2026
Kobzol
reviewed
Mar 6, 2026
79a594b to
4f9726f
Compare
Kobzol
reviewed
Mar 6, 2026
| }; | ||
|
|
||
| // Ensure this an issue | ||
| let issue = repository |
Member
There was a problem hiding this comment.
Note that this doesn't actually check if the issue isn't a PR, e.g. this works: gh api /repos/rust-lang/rust/issues/153503 for rust-lang/rust#153503. I think you wanted to check it based on this PR's description (?). You can just check if issue.pull_request is not None, and error out in that case.
Contributor
Author
There was a problem hiding this comment.
yeah sort of. Since we have this method that returns error if the issue number provided is not a pull request, I thought get_issue() worked the other way (and admittedly didn't test).
I'll use issue.pull_request() as you suggest, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triagebot learns how to post a comment on GitHub to assign priority to an issue that is marked as regression. The command is sent from the Zulip Rust lang chat instance. The syntax is:
@triagebot prio #issue <priority>example
@triagebot prio #123456 highThe comment on GitHub is my usual comment on issue priority:
This handler checks that:
r? @Urgau
Thanks for a review!