Skip to content

Show recent PRs when a user is banned#2313

Merged
Kobzol merged 4 commits intorust-lang:masterfrom
Kobzol:recent-prs
Mar 1, 2026
Merged

Show recent PRs when a user is banned#2313
Kobzol merged 4 commits intorust-lang:masterfrom
Kobzol:recent-prs

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Mar 1, 2026

A related request was posted here, but in general I think that this might be useful. Similar code can also be reused for showing "recent user statistics", which I plan on working next.

This is how the output now looks like for me:

User kobzol was banned from the rust-lang organization by kobzol.

View user profile

Recent comments:

Recent PRs:

Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

View changes since this review

@Kobzol Kobzol enabled auto-merge March 1, 2026 11:54
@Kobzol Kobzol added this pull request to the merge queue Mar 1, 2026
@apiraino
Copy link
Contributor

apiraino commented Mar 1, 2026

I personally prefer another style for titles in Markdown, it helps slightly reducing the visual clutter when there are other links the body, example:

Recent PRs:

What do you think? (Not a big deal in any case)

Merged via the queue into rust-lang:master with commit ca3c55b Mar 1, 2026
3 checks passed
@Kobzol Kobzol deleted the recent-prs branch March 1, 2026 12:08
@Kobzol
Copy link
Member Author

Kobzol commented Mar 1, 2026

That looks good! I'll modify it in a follow-up PR.

@ZuseZ4
Copy link
Member

ZuseZ4 commented Mar 1, 2026

@Kobzol I got a notification on this PR, because you mentioned me in one of your last PRs. I assume this feature will be used somewhat often, so pinging a lot of people on a potential llm spam account seems counterproductive?

@marcoieni
Copy link
Member

Maybe triagebot can escape mentions (eg @marcoieni) so that people aren't pinged

@Kobzol
Copy link
Member Author

Kobzol commented Mar 2, 2026

Sorry for the ping! Don't worry, you won't be pinged. This message is only shown in a private stream only available to mods.

That being said, escaping @ is a good idea, as similar text might be shown on other Zulip command output. I'll escape it.

@Kobzol
Copy link
Member Author

Kobzol commented Mar 2, 2026

Will be done in #2317.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants