-
Notifications
You must be signed in to change notification settings - Fork 97
Automatically create tracking issues when major change are accepted #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
I don't want to smother you with extra work, so these things can be done as follow-ups (or not all :P): In my issue & MCP I also proposed to
-
have some
suppress-auto-trackinglabel to suppress the creation of the tracking issue.So it would be pretty great if one was able to register such a label in
[major-change.tracking-issue-template]assuming you agree that such a mechanism would be useful (IIRC @Kobzol doubted the usefulness).That could come in clutch in situations like open MCP Remove diagnostic translation infrastructure compiler-team#924 where we already have a tracking issue: Tracking Issue for rustc's translatable diagnostics infrastructure rust#132181 (sort of). And IIRC my MCP / issue had some other vague examples?
-
have a way to ping the MCP author (and registered mentors if technically feasible) since the link to the MCP can be easily missed; however, it's probably not worth the effort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- have some
suppress-auto-trackinglabel to suppress the creation of the tracking issue
While I don't doubt the usefulness in some scenario I think they are going to be extremely limited. Even in your example I would still want to have the tracking issue created as they wouldn't track the same thing.
If we see the need for it we can always add it later.
- have a way to ping the MCP author
Done, added the ${mcp_author} variable to get the handle of the MCP issue author.
- and registered mentors if technically feasible
That would require some sort of easily-parseble format for triagebot, it's currently a free for all. Let's defer that for now.
0185245 to
16c51bc
Compare
This PR adds the required infrastructure to automatically create a tracking issues when a major change is accepted.
Fixes #2067
cc @fmease