Skip to content

add unclaim as an alias for release-assignment #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Urgau merged 3 commits into from
Aug 6, 2025
Merged

add unclaim as an alias for release-assignment #2135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5219533
add unclaim as an alias for release-assignment
lolbinarycat Aug 5, 2025
513c1e1
add unit test for "unclaim" alias
lolbinarycat Aug 5, 2025
4695335
update AssignCommand doc comment to acknowladge unclaim
lolbinarycat Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions parser/src/command/assign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use std::fmt;
pub enum AssignCommand {
/// Corresponds to `@bot claim`.
Claim,
/// Corresponds to `@bot release-assignment`.
/// Corresponds to `@bot release-assignment` or `@bot unclaim`.
ReleaseAssignment,
/// Corresponds to `@bot assign @user`.
AssignUser { username: String },
Expand Down Expand Up @@ -68,7 +68,7 @@ impl AssignCommand {
} else {
return Err(toks.error(ParseError::NoUser));
}
} else if let Some(Token::Word("release-assignment")) = toks.peek_token()? {
} else if let Some(Token::Word("release-assignment" | "unclaim")) = toks.peek_token()? {
toks.next_token()?;
if let Some(Token::Dot) | Some(Token::EndOfLine) = toks.peek_token()? {
toks.next_token()?;
Expand Down Expand Up @@ -181,4 +181,9 @@ mod tests {
)
}
}

#[test]
fn unclaim() {
assert_eq!(parse("unclaim"), Ok(Some(AssignCommand::ReleaseAssignment)));
}
}