Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Jul 16, 2025

This PR renames (while keeping compatibility for the names) [assign.custom-welcome-messages] and it's fields to:

[assign.custom_messages]
auto-assign-someone = "Welcome message, assigning {assignee}!"
auto-assign-no-one = "Welcome message for when no reviewer could be found!"
Old syntax
[assign.custom_welcome_messages]
welcome-message = "Welcome message, assigning {assignee}!"
welcome-message-no-reviewer = "Welcome message for when no reviewer could be found!"

This is done in order to be less confusing to users as "welcome" can be confused with a first time welcome message instead of the meaning we use, namely the welcome message of the PR. I also took the opportunity to clarify the fields meaning (in particular regarding manual-assign).

Reported at rust-lang/miri#4472 (comment).

Only the last commit is relevant.

@Urgau Urgau requested a review from Kobzol July 16, 2025 20:47
@Urgau Urgau added this pull request to the merge queue Jul 17, 2025
Merged via the queue into rust-lang:master with commit 817268e Jul 17, 2025
3 checks passed
@Urgau Urgau deleted the assign-custom-messages-rename branch July 17, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants