Quote review suggestions in comments #1783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like an innocent cosmetic change now but it become critical when we will implement the new review assignment.
In case a pull request review cannot be assigned (for any reason), the triagebot will post a comment on GitHub. The text of the comment does not quote correctly the "r?" wording, example "Use r? to specify someone else to assign.".
That could trigger an infinite loop where the words "r? to" are interpreted by the triagebot receiving the webhook after posting that command.
Quoting with markdown will prevent this loop.
I am not sure this patch solves 100% of the all cases but it should cover most of them.
r? @jackh726