Skip to content

Don't post mentions for draft PRs. #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mark-Simulacrum merged 1 commit into from
Jul 18, 2022
Merged

Don't post mentions for draft PRs. #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,8 @@ pub struct Issue {
pub pull_request: Option<PullRequestDetails>,
#[serde(default)]
pub merged: bool,
#[serde(default)]
pub draft: bool,
// API URL
comments_url: String,
#[serde(skip)]
Expand Down
6 changes: 3 additions & 3 deletions src/handlers/mentions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ pub(super) async fn parse_input(

if !matches!(
event.action,
IssuesAction::Opened | IssuesAction::Synchronize
IssuesAction::Opened | IssuesAction::Synchronize | IssuesAction::ReadyForReview
) {
return Ok(None);
}

// Don't ping on rollups.
if event.issue.title.starts_with("Rollup of") {
// Don't ping on rollups or draft PRs.
if event.issue.title.starts_with("Rollup of") || event.issue.draft {
return Ok(None);
}

Expand Down