Skip to content

reviewers.rs: remove manual addition of some reviewers - #98

Merged
Kobzol merged 3 commits into
rust-lang:mainfrom
DanielEScherzer:patch-1
Sep 1, 2026
Merged

reviewers.rs: remove manual addition of some reviewers#98
Kobzol merged 3 commits into
rust-lang:mainfrom
DanielEScherzer:patch-1

Conversation

@DanielEScherzer

@DanielEScherzer DanielEScherzer commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Will Crichton, Hanna Kruppe and Petr Hosek are now present in rust-lang/team.

@DanielEScherzer

Copy link
Copy Markdown
Contributor Author

Not sure if a manual alias is also needed for this

@Kobzol

Kobzol commented Aug 13, 2026

Copy link
Copy Markdown
Member

This might require a mailmap entry to merge the two e-mails (the team e-mail is different). Let's do that once we have tests.

Because they are in the team repository now.
@Kobzol Kobzol changed the title reviewers.rs: remove manual addition of willcrichton reviewers.rs: remove manual addition of some reviewers Sep 1, 2026
@Kobzol

Kobzol commented Sep 1, 2026

Copy link
Copy Markdown
Member

Submitted rust-lang/rust#162111 to update the mailmap entry.

@Kobzol

Kobzol commented Sep 1, 2026

Copy link
Copy Markdown
Member

Note that when blessing the snapshots, the mailmap won't be updated, because it still reads the old mailmap. But I think that is fine. I'll make it possible to run thanks on a custom mailmap to make it easier to check whether mailmap changes produce the expected output.

@Kobzol
Kobzol enabled auto-merge September 1, 2026 09:52
@Kobzol
Kobzol merged commit ab6c8e5 into rust-lang:main Sep 1, 2026
6 checks passed
@DanielEScherzer
DanielEScherzer deleted the patch-1 branch September 1, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants