-
Notifications
You must be signed in to change notification settings - Fork 326
Sync Discord Roles #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Discord Roles #538
Conversation
|
Wow, thanks for working on this!! 👏 |
pietroalbini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
In the past we added validation rules (in src/validation.rs) to ensure everyone on a team had access to the service when configuring the service for the team. In Discord's case, this would mean that every member of a team with a Discord role would have to have a Discord ID in their profile.
This is the behavior we want for every team but Teams and WGs, and we should probably add a allow-members-without-discord-id = true to that [[discord-role]] (possibly with a better name).
|
@sebasmagri can you send me or post here your discord-id? Im not 100% sure if your actually on discord and I want to make sure I have the right user. |
It's |
…m when pulling down discord users
|
Thanks |
This PR adds support for syncing team members discord roles with their membership in the teams api.
In addition, this PR adds discord-role entries to the docs-rs, infra, and community teams.
A team that
[[discord-roles]]in the team configdiscord-idin the people configwill have their members automatically updated on discord with that corresponding teams role.
Examples of discord role in team config
Blocks: rust-lang/sync-team#2