Skip to content

Conversation

@technetos
Copy link
Member

@technetos technetos commented Feb 17, 2021

This PR adds support for syncing team members discord roles with their membership in the teams api.

In addition, this PR adds discord-role entries to the docs-rs, infra, and community teams.

A team that

  1. Has at least 1 [[discord-roles]] in the team config
  2. Has members who have their discord-id in the people config

will have their members automatically updated on discord with that corresponding teams role.

Examples of discord role in team config

[discord-role]
name = "community-team" // required
color = "#000000" // optional

Blocks: rust-lang/sync-team#2

@technetos technetos marked this pull request as ready for review February 17, 2021 01:37
@Manishearth
Copy link
Member

Wow, thanks for working on this!! 👏

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

In the past we added validation rules (in src/validation.rs) to ensure everyone on a team had access to the service when configuring the service for the team. In Discord's case, this would mean that every member of a team with a Discord role would have to have a Discord ID in their profile.

This is the behavior we want for every team but Teams and WGs, and we should probably add a allow-members-without-discord-id = true to that [[discord-role]] (possibly with a better name).

@technetos
Copy link
Member Author

@sebasmagri can you send me or post here your discord-id? Im not 100% sure if your actually on discord and I want to make sure I have the right user.

@sebasmagri
Copy link

@sebasmagri can you send me or post here your discord-id? Im not 100% sure if your actually on discord and I want to make sure I have the right user.

It's sebasmagri#9756 :-)

@pietroalbini pietroalbini merged commit fba4743 into rust-lang:master Apr 24, 2021
@pietroalbini
Copy link
Member

Thanks

@ehuss ehuss mentioned this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants